Skip to content

_sandboxreapi: check stdout and stderr exist when fetching action result #2045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juergbi merged 1 commit into from
Sep 19, 2025
Merged

_sandboxreapi: check stdout and stderr exist when fetching action result #2045

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/buildstream/sandbox/_sandboxreapi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,8 +184,13 @@ def _fetch_action_result_outputs(self, casremote, action_result):

raise SandboxError("Output directory structure had no digest attached.")

# Fetch stdout and stderr blobs
cascache.fetch_blobs(casremote, [action_result.stdout_digest, action_result.stderr_digest])
# Fetch stdout and stderr blobs, if they exist
blobs = []
for digest in [action_result.stdout_digest, action_result.stderr_digest]:
if digest.hash:
blobs.append(digest)
if blobs:
cascache.fetch_blobs(casremote, blobs)

def _process_job_output(self, working_directory, output_directories, output_files, *, failure):
# Reads the remote execution server response to an execution request.
Expand Down
Loading