_sandboxremote.py: stop trying to pull partial artifacts#2032
Merged
_sandboxremote.py: stop trying to pull partial artifacts#2032
Conversation
abderrahim
requested review from
BenjaminSchubert,
cs-shadow,
gtristan and
juergbi
as code owners
abderrahim
force-pushed
the
abderrahim/sandbox-remote-no-artifactcache
branch
from
0ef347e to
2286042
Compare
juergbi
approved these changes
Jul 11, 2025
There used to be a time where buildstream could partially download artifacts, which could mean that not all artifact blobs are available locally. This is no longer the case: support for partial artifacts was dropped in favour of the cache storage-service and is only used for buildtrees, which aren't used in this case. Downloading missing blobs from the cache storage-service is handled in `CASCache._send_blobs()` called a few lines below.
These were related to partial artifacts and are no longer used
abderrahim
force-pushed
the
abderrahim/sandbox-remote-no-artifactcache
branch
from
2286042 to
e867d6f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There used to be a time where buildstream could partially download artifacts,
which could mean that not all artifact blobs are available locally. This is no
longer the case: support for partial artifacts was dropped in favour of the
cache storage-service and is only used for buildtrees, which aren't used in
this case.
Downloading missing blobs from the cache storage-service is handled in
CASCache._send_blobs()called a few lines below.This PR also drops
ArtifactCache.{fetch,find}_missing_blobs()which are unused.