tests: use importlib.metadata instad of pkg_resources#2025
Merged
abderrahim merged 2 commits intomasterfrom Jul 6, 2025
Merged
tests: use importlib.metadata instad of pkg_resources#2025abderrahim merged 2 commits intomasterfrom
abderrahim merged 2 commits intomasterfrom
Conversation
abderrahim
requested review from
BenjaminSchubert,
cs-shadow,
gtristan and
juergbi
as code owners
abderrahim
force-pushed
the
abderrahim/pkg_resources
branch
4 times, most recently
from
5e6a615 to
5b788cd
Compare
abderrahim
commented
Jun 28, 2025
abderrahim
changed the title
abderrahim
force-pushed
the
abderrahim/pkg_resources
branch
2 times, most recently
from
99e6e3f to
9b5f754
Compare
juergbi
approved these changes
Jul 4, 2025
Contributor
juergbi
left a comment
juergbi
left a comment
There was a problem hiding this comment.
I assume types-setuptools can be removed from tox.ini as well.
LGTM overall, assuming CI passes on all Python versions.
This file was used by a test `tests/plugins/third_party.py`, which was removed in c7f69bc
abderrahim
force-pushed
the
abderrahim/pkg_resources
branch
from
9b5f754 to
c1b4827
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #1948