core warnings for missing Source.collect_source_info() implementations#2018
Merged
abderrahim merged 3 commits intomasterfrom Jun 2, 2025
Merged
core warnings for missing Source.collect_source_info() implementations#2018abderrahim merged 3 commits intomasterfrom
abderrahim merged 3 commits intomasterfrom
Conversation
gtristan
requested review from
BenjaminSchubert,
abderrahim,
cs-shadow and
juergbi
as code owners
gtristan
force-pushed
the
tristan/source-info-fatal-warning
branch
from
62bf6b9 to
861c7e9
Compare
abderrahim
approved these changes
Jun 2, 2025
Contributor
abderrahim
left a comment
abderrahim
left a comment
There was a problem hiding this comment.
A couple minor comments.
tests/frontend/source-info-unimplemented/fatal/elements/unimplemented.bst
Show resolved
Hide resolved
… unimplemented This allows the project to have a policy of only allowing usage of sources which implement Source.collect_source_info() (or SourceFetcher.get_source_info()).
This elaborates on the unimplemented test case to check behavior of fatal vs non-fatal warnings.
gtristan
force-pushed
the
tristan/source-info-fatal-warning
branch
from
861c7e9 to
cac1ea8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows projects to have a policy for only using sources which provide the new source provenance introspection routines.