Skip to content

Sync the protobuf version requirements with grpcio-tools #2017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abderrahim merged 2 commits into from
Jun 2, 2025
Merged

Sync the protobuf version requirements with grpcio-tools #2017

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
839ea42
sync protobuf requirements with the grpcio-tools version used
abderrahim Jun 2, 2025
5e9eb76
Add note to update the requirements whenever the grpc code is regener…
abderrahim Jun 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions doc/source/hacking/grpc_protocols.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,3 +36,6 @@ To actually regenerate the code::

./setup.py build_grpc

The ``requirements/requirements.in`` file needs to be updated to match the
protobuf version requirements of the ``grpcio-tools`` version used to
generate the code.
2 changes: 1 addition & 1 deletion requirements/requirements.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Jinja2 >= 2.10
importlib_metadata >= 3.6; python_version < "3.10"
packaging
pluginbase
protobuf >= 3.19
protobuf <6.0dev,>=5.26.1
psutil
ruamel.yaml >= 0.16.7
ruamel.yaml.clib >= 0.1.2
Expand Down
6 changes: 6 additions & 0 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,12 @@ def run(self):
with open(path, "w", encoding="utf-8") as f:
f.write(code)

print(
"\n"
"NOTE: Please update requirements/requirements.in to match the protobuf\n"
"requirement in the grpcio-tools version you used."
)


def get_cmdclass():
cmdclass = {
Expand Down
Loading