node.pyx: Support loading 0/1 as boolean values#2011
Merged
Conversation
This oddly suddenly started causing my compiler to crash locally today, and the raise statement does appear dubious, and the string formatting has too many arguments, bool.__name__ appears to trigger the compiler crash.
It turns out that since OptionBool.get_value() is serializing boolean values as "0"/"1", we must support this in node parsing. This is because we should be able to use option value exporting to values, which can subsequently be specified in plugin configuration which wants to use MappingNode.get_bool(). Fixes #2006
…lues This simply ensures that the values which got exported can be directly consumed by plugin node configuration.
gtristan
requested review from
BenjaminSchubert,
abderrahim,
cs-shadow and
juergbi
as code owners
This test was checking validity of yaml configuration, and now that "1"/"0" are valid boolean values, this test needed to be updated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It turns out that since OptionBool.get_value() is serializing boolean values as "0"/"1", we must support this in node parsing.
This is because we should be able to use option value exporting to values, which can subsequently be specified in plugin configuration which wants to use
MappingNode.get_bool().Fixes #2006