Skip to content

casdprocessmanager.py: Don't use preexec_fn on Python 3.11+ #1980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juergbi merged 1 commit into from
Jan 18, 2025
Merged

casdprocessmanager.py: Don't use preexec_fn on Python 3.11+ #1980

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions src/buildstream/_cas/casdprocessmanager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
import shutil
import stat
import subprocess
import sys
import tempfile
import time
from subprocess import CalledProcessError
Expand Down Expand Up @@ -126,16 +127,21 @@ def __init__(
self._start_time = time.time()
self._logfile = self._rotate_and_get_next_logfile()

# Create a new process group for buildbox-casd such that SIGINT won't reach it.
if sys.version_info >= (3, 11):
process_group_kwargs = {"process_group": 0}
else:
process_group_kwargs = {"preexec_fn": os.setpgrp}

with open(self._logfile, "w", encoding="utf-8") as logfile_fp:
# The frontend will take care of terminating buildbox-casd.
# Create a new process group for it such that SIGINT won't reach it.
self.process = subprocess.Popen( # pylint: disable=consider-using-with, subprocess-popen-preexec-fn
self.process = subprocess.Popen( # pylint: disable=consider-using-with
casd_args,
cwd=path,
stdout=logfile_fp,
stderr=subprocess.STDOUT,
preexec_fn=os.setpgrp,
env=self.__buildbox_casd_env(),
**process_group_kwargs
)

self._casd_channel = None
Expand Down
Loading