contrib/bst-graph: Escape names when using as node_id#1979
Merged
juergbi merged 2 commits intoapache:masterfrom Feb 7, 2025
Merged
contrib/bst-graph: Escape names when using as node_id#1979juergbi merged 2 commits intoapache:masterfrom
juergbi merged 2 commits intoapache:masterfrom
Conversation
harrysarson
requested review from
BenjaminSchubert,
abderrahim,
cs-shadow,
gtristan and
juergbi
as code owners
juergbi
reviewed
Jan 10, 2025
Contributor
|
Please prefix your commit summaries with |
juergbi
changed the title
Colons in node_ids generate invalid graphviz, therefore escape the name and use a `label` attribute to render correct name in the graph.
Without raw string I see `SyntaxWarning: invalid escape sequence '\|'`.
harrysarson
force-pushed
the
harry/graph
branch
from
4b334fe to
655e658
Compare
Contributor
Author
Done |
juergbi
approved these changes
Feb 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Colons in node_ids generate invalid graphviz, therefore escape the name
and use a
labelattribute to render correct name in the graph.This PR also uses a raw string for the regex to fix
SyntaxWarning: invalid escape sequence '\|'.