_loader/loader.py: Add None checks for shallow loading#1975
Merged
Conversation
Contributor
|
It would be good to document the functions which can newly now return |
juergbi
force-pushed
the
juerg/loader
branch
from
6cd5981 to
432d51c
Compare
gtristan
approved these changes
Dec 11, 2024
Contributor
gtristan
left a comment
gtristan
left a comment
There was a problem hiding this comment.
Looks good to me, this might or might not fix the crashes but doesn't break tests and is otherwise harmless, possibly helping us track down issues which were leading to this None dereferencing.
juergbi
requested review from
BenjaminSchubert,
abderrahim and
cs-shadow
as code owners
When performing shallow loads without loading subprojects, `get_loader()` may return `None`. Add checks for that to fix crashes dereferencing `None`.
juergbi
force-pushed
the
juerg/loader
branch
from
432d51c to
7eacebe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When performing shallow loads without loading subprojects,
get_loader()may returnNone. Add checks for that to fix crashes dereferencingNone.