Skip to content

Allow configuring sandbox option casd-socket #1945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nanonyme wants to merge 1 commit into from
Closed

Allow configuring sandbox option casd-socket #1945

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/buildstream/sandbox/_sandboxbuildboxrun.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,15 @@ def _execute_action(self, action, flags):
else:
stdin = subprocess.DEVNULL

if "casd-socket" in self.__config:
Copy link
Contributor

@abderrahim abderrahim Oct 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably a mistake: self.__config doesn't seem to exist here.

Copy link
Contributor Author

@nanonyme nanonyme Oct 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, is it the name mangling? self.__config belongs to grandparent of this class, Sandbox.

Copy link
Contributor

@abderrahim abderrahim Dec 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, anything that starts with two underscores is private to a class (and python enforces it)

# Expose the casd socket in the sandbox
buildbox_command.append(
"--bind-mount={}:{".format(
casd_process_manager._socket_path,
self.__config["casd-socket"],
)
)

self._run_buildbox(
buildbox_command,
stdin,
Expand Down