Merged
Conversation
nanonyme
force-pushed
the
pre-exec
branch
2 times, most recently
from
9675062 to
91c47a3
Compare
nanonyme
requested review from
BenjaminSchubert,
abderrahim,
cs-shadow,
gtristan and
juergbi
as code owners
Contributor
Author
|
The leading idea here is that the time between fork and exec is perilous and we can avoid an unnecessary context switch from C code to Python code by using Python builtin umask setting functionality. The os.umask call itself is fine but the dance to make existing pre-exec function work through creating a Python wrapper means we do a context switch. |
Contributor
Author
|
I will remove workaround and wait until BuildStream is ready to drop Python 3.8. |
nanonyme
changed the title
juergbi
approved these changes
Dec 14, 2024
Contributor
juergbi
left a comment
juergbi
left a comment
There was a problem hiding this comment.
Looks good to me. As the release process for 2.4.0 has already started, it may be a bit late to get this still in before the release, though.
Contributor
|
We should be able to remove |
Contributor
Author
|
@juergbi removed the stanza. |
nanonyme
commented
Jan 3, 2025
This requires Python 3.9 or newer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This requires Python 3.9 or newer