Conversation
gtristan
requested review from
BenjaminSchubert,
abderrahim,
cs-shadow and
juergbi
as code owners
The v1 and v2 versions are now deprecated and don't work: https://github.blog/changelog/2024-02-13-deprecation-notice-v1-and-v2-of-the-artifact-actions/
gtristan
force-pushed
the
tristan/workaround-broken-ci
branch
from
dc2262c to
61a1871
Compare
abderrahim
reviewed
Dec 3, 2024
gtristan
force-pushed
the
tristan/workaround-broken-ci
branch
2 times, most recently
from
8eb696c to
e5c116c
Compare
gtristan
force-pushed
the
tristan/workaround-broken-ci
branch
2 times, most recently
from
51d523f to
8cea980
Compare
gtristan
force-pushed
the
tristan/workaround-broken-ci
branch
3 times, most recently
from
3589014 to
efa9e90
Compare
juergbi
reviewed
Dec 6, 2024
juergbi
reviewed
Dec 6, 2024
Contributor
juergbi
left a comment
juergbi
left a comment
There was a problem hiding this comment.
Except for the pylint workaround, this looks good to me.
We should also add support for Python 3.13 to tox and CI and drop references to Python 3.8, matching BuildStream. However, we can do this in a follow-up.
This doesnt play well with parameterized pytest tests.
This is a workaround for https://issues.apache.org/jira/browse/INFRA-26331 As outlined here: https://etbe.coker.com.au/2024/04/24/ubuntu-24-04-bubblewrap/ Bubblewrap is not working on ubuntu 24 without some adjustments.
We had a regression where we are not running bzr related tests, which also includes the cache key test. Also use ubuntu 22.04 instead of 20.04, because the 20.04 image went missing in upstream buildstream-docker-images.
This fixes the docs build.
Since bzr is not implemented with breezy, and breezy uses a python library, we cannot execute bzr on some platforms without installing the breezy python libs into the tox venv, and we cannot install breezy into the venv easily since it is installing from source, and using things like cython and rust. Instead, we simply wrap host bzr with a script which overrides the PATH variable, so that python ignores the venv when entering the bzr code, this allows us to keep our tox environment clean for buildstream and tests, while testing the host installation of bzr.
gtristan
force-pushed
the
tristan/workaround-broken-ci
branch
from
efa9e90 to
335a4b1
Compare
juergbi
approved these changes
Dec 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses ubuntu 22.04 runners, as a workaround for https://issues.apache.org/jira/browse/INFRA-26331, as outlined here: https://etbe.coker.com.au/2024/04/24/ubuntu-24-04-bubblewrap/ bubblewrap is not working on ubuntu 24 without some adjustments.
Also this fixes some linting errors, updates the artifact APIs, uses a new testsuite image which contains bzr, and fixes bzr tests, so all tests are working again.