Conversation
gtristan
requested review from
BenjaminSchubert,
abderrahim,
cs-shadow and
juergbi
as code owners
gtristan
force-pushed
the
tristan/mirror-plugins
branch
4 times, most recently
from
65dcfcb to
ee77104
Compare
gtristan
force-pushed
the
tristan/mirror-plugins
branch
3 times, most recently
from
f1eee1d to
a74771d
Compare
This makes reference to the format-version from BuildStream 1, but this plugin is for BuildStream 2 and has been available since the initial buildstream-plugins release.
Bumping version to 2.4.0, for the addition of the source mirror plugins.
gtristan
force-pushed
the
tristan/mirror-plugins
branch
from
a74771d to
94c004d
Compare
Since we've added the SourceMirror feature in BuildStream 2.2, it makes sense to add this mirror plugin upstream. This is especially helpful as we can rely on loading stable buildstream-plugins via the `pip` plugin origin for loading source mirror plugins, avoiding a cyclic dependency issue if you want to use mirror plugins to load plugins via the `junction` plugin origin.
Since we've added the SourceMirror feature in BuildStream 2.2, it makes sense to add this mirror plugin upstream. This is especially helpful as we can rely on loading stable buildstream-plugins via the `pip` plugin origin for loading source mirror plugins, avoiding a cyclic dependency issue if you want to use mirror plugins to load plugins via the `junction` plugin origin.
gtristan
force-pushed
the
tristan/mirror-plugins
branch
from
94c004d to
6773903
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the source mirror plugins from https://gitlab.com/BuildStream/buildstream-plugins-community.
These have been tested and used internally at codethink for a while and are working well.
These plugins are authored by Abderrahim Kitouni and are acceptable to release under the ASF license.