Skip to content

Fix PreCommit Xlang Generated Transforms job#37717

Merged
damccorm merged 1 commit intomasterfrom
fix-generated-transforms
Feb 26, 2026
Merged

Fix PreCommit Xlang Generated Transforms job#37717
damccorm merged 1 commit intomasterfrom
fix-generated-transforms

Conversation

@Amar3tto
Copy link
Collaborator

Fixes #36481
Successful runs:
https://github.com/apache/beam/actions/runs/22443970856
https://github.com/apache/beam/actions/runs/22443442502


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@Amar3tto Amar3tto requested a review from damccorm February 26, 2026 13:40
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Amar3tto, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses flakiness in the "PreCommit Xlang Generated Transforms" job by implementing deterministic sorting for external transform configurations. The changes ensure that both the generated configuration files and the comparison logic in the integration test consistently handle the ordering of transforms and their parameters, thereby stabilizing the build process.

Highlights

  • Test Stability: Introduced a normalization function in external_transform_provider_it_test.py to sort external transform configurations and their fields deterministically before comparison, resolving flakiness caused by non-deterministic ordering.
  • Configuration Generation: Updated gen_xlang_wrappers.py to ensure that discovered external transforms and their configuration parameters are processed in a deterministic order, leading to consistent generated configuration files.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • sdks/python/apache_beam/transforms/external_transform_provider_it_test.py
    • Added a _normalize helper function to sort test_config and standard_config before assertion.
    • Modified the assertEqual call to use the normalized configurations.
  • sdks/python/gen_xlang_wrappers.py
    • Changed iteration over discovered.items() to sorted(discovered.keys()) to process transforms deterministically.
    • Changed iteration over wrapper.configuration_schema.values() to sorted(wrapper.configuration_schema.keys()) to process parameters deterministically.
Activity
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@damccorm damccorm merged commit 2403014 into master Feb 26, 2026
95 of 98 checks passed
@damccorm damccorm deleted the fix-generated-transforms branch February 26, 2026 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The PreCommit Xlang Generated Transforms job is flaky

2 participants