Add observability

[tarun-google]

Export script metrics to Cloud Monitoring

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

[gemini-code-assist]

Summary of Changes

Hello @tarun-google, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the observability of the Envoy Rate Limiter example by transitioning its metrics collection from StatsD to native Prometheus, with direct export to Google Cloud Monitoring. This change provides more robust and integrated monitoring capabilities. Additionally, the deployment experience has been improved through the introduction of an automated helper script, simplifying the setup and teardown of the rate limiter service.

Highlights

• Observability Integration: Integrated native Prometheus metrics with Google Cloud Monitoring for the Envoy Rate Limiter, replacing the previous StatsD exporter.
• Simplified Deployment: Introduced a new deploy.sh helper script to automate the Terraform deployment and destruction processes for the Envoy Rate Limiter.
• Metrics Enabled by Default: Changed the default setting for enable_metrics to true, ensuring observability is active out-of-the-box.
• Documentation Updates: Updated the README.md to reflect the new Prometheus metrics, the default enablement of metrics, and the streamlined deployment instructions.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• examples/terraform/envoy-ratelimiter/README.md
  • Updated the description of metrics to reflect Prometheus integration and export to Google Cloud Monitoring.
  • Changed the default value for enable_metrics in the example configuration to true.
  • Revised deployment instructions to recommend and detail the use of the new deploy.sh script.
  • Added a new section dedicated to 'Observability & Metrics', including sample metrics and viewing instructions for Google Cloud Console.
  • Updated cleanup instructions to include the deploy.sh destroy command.
• examples/terraform/envoy-ratelimiter/deploy.sh
  • Added a new shell script to automate the Terraform init, apply, and destroy commands for the Envoy Rate Limiter.
• examples/terraform/envoy-ratelimiter/prerequisites.tf
  • Added the monitoring Google Cloud service to the list of required project services.
• examples/terraform/envoy-ratelimiter/ratelimit.tf
  • Modified the kubernetes_deployment resource to expose a Prometheus metrics port (9090) dynamically when metrics are enabled.
  • Replaced USE_STATSD environment variable with USE_PROMETHEUS and configured PROMETHEUS_ADDR and PROMETHEUS_PATH.
  • Removed the STATSD_HOST and STATSD_PORT environment variables.
  • Removed the statsd-exporter sidecar container definition.
  • Added a kubernetes_manifest resource to create a PodMonitoring object for Google Cloud Monitoring, targeting the rate limit service's Prometheus endpoint.
• examples/terraform/envoy-ratelimiter/variables.tf
  • Changed the default value of the enable_metrics variable from false to true.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[tarun-google]

R: @damccorm

[github-actions]

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

[damccorm]

/gemini review

[gemini-code-assist]

Code Review

This pull request introduces observability for the Envoy Rate Limiter by enabling native Prometheus metrics and exporting them to Google Cloud Monitoring. It replaces the previous statsd-exporter sidecar with a more integrated approach using GKE's PodMonitoring resource. A new deploy.sh script is also added to simplify deployment and teardown. The changes are solid, but I have a few suggestions to improve documentation clarity and Terraform code consistency. Specifically, I've pointed out an outdated variable description, some confusing documentation in the README, a misleading comment in the new deploy script, and an opportunity to make environment variable configuration more robust in the Terraform code.

[damccorm]

Thanks - LGTM, though I'll see if Gemini has suggestions

[tarun-google]

let me fix some gemini suggestions. I will do a quick round of testing with those and notify

[tarun-google]

Tested changes again for sanity. This is good to go from my end. Thank you !

[damccorm]

Thanks!