Fix PostCommit Python Xlang IO Dataflow job#37712
Conversation
Summary of ChangesHello @Amar3tto, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the Python wheel build process by isolating the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Ignored Files
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Thanks. Do we know which PR has caused
Can we simply install it back? If not possible, could we install the dependency in place, e.g. Maintaining two virtualenv for a single task sounds adding more overhead. |
PR that caused: #37504 |
|
I changed |
I see, this suggests version selection for Python 3.10 https://github.com/apache/beam/pull/37504/changes#diff-538277aecfad235f4cd18a6a6b521b1bea96d34c5a89e8d3b769e766f38e3f14R203 is not working as intended. We should be able to patch there I would suggest reverting that PR for now. cc: @jrmccluskey |
|
There's a reversion out at #37713 now, looks like the 3.10 case isn't working right here. I'd prefer we fix forward since that split has to happen for 3.14 support but if that's going to be a bigger effort we can just put the reversion through |
Fixes #33253
Successful run: https://github.com/apache/beam/actions/runs/22408286727/job/64874345301
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.