Skip to content

Fix PreCommit tests involving docker-in-docker after Milvus dependency rearrangements#37711

Merged
Abacn merged 1 commit intoapache:masterfrom
Abacn:fixdindtest
Feb 25, 2026
Merged

Fix PreCommit tests involving docker-in-docker after Milvus dependency rearrangements#37711
Abacn merged 1 commit intoapache:masterfrom
Abacn:fixdindtest

Conversation

@Abacn
Copy link
Contributor

@Abacn Abacn commented Feb 25, 2026

Fix #30813

After #37668, Milvus dependency isn't installed for both Python Coverage and Python ML PreCommit and the matrix failed due to empty set.

Solution: remove DinD matrix from Python Coverage; and add milvus dependency back to Python ML PreCommit DinD


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Abacn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses pre-commit test failures by correctly including the milvus_dependency in the p313_ml_test environment within the Python SDK's setup.py. This ensures that tests involving Milvus dependencies run successfully, maintaining the stability of the build process after recent Milvus dependency rearrangements.

Highlights

  • Dependency Management: Added milvus_dependency to the p313_ml_test environment in setup.py to resolve pre-commit test failures related to Milvus.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • sdks/python/setup.py
    • Included milvus_dependency in the p313_ml_test environment definition.
Ignored Files
  • Ignored by pattern: .github/workflows/** (2)
    • .github/workflows/beam_PreCommit_Python_Coverage.yml
    • .github/workflows/beam_PreCommit_Python_ML.yml
Activity
  • No specific activity (comments, reviews) has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@Abacn
Copy link
Contributor Author

Abacn commented Feb 25, 2026

Tests passed: Coverage: https://github.com/apache/beam/actions/runs/22409181700

ML: https://github.com/apache/beam/actions/runs/22409192805 (there is another breakage due to sklearn dependency in Python 3.10/3.11 not relevant here)

@Abacn Abacn marked this pull request as ready for review February 25, 2026 18:38
@Abacn
Copy link
Contributor Author

Abacn commented Feb 25, 2026

R: @shunping @aIbrahiim @Amar3tto

@Abacn
Copy link
Contributor Author

Abacn commented Feb 25, 2026

R: @claudevdm

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@Abacn Abacn merged commit caf6617 into apache:master Feb 25, 2026
94 of 107 checks passed
@Abacn Abacn deleted the fixdindtest branch February 25, 2026 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The PreCommit Python Coverage job is flaky

2 participants