revert 'Optimize data size estimation for proto coder.'

[stankiewicz]

Revert #37584

---

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

• Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
• Update CHANGES.md with noteworthy changes.
• If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

[gemini-code-assist]

Summary of Changes

Hello @stankiewicz, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request undoes a prior optimization aimed at improving data size estimation for Protocol Buffer coders within the Apache Beam Python SDK. The revert removes the custom estimate_size implementations for both standard and 'proto plus' Protocol Buffer coders, effectively restoring their previous behavior regarding size estimation.

Highlights

• Reverted Data Size Estimation Optimization: This pull request reverts a previous change that optimized data size estimation for proto coders. Specifically, the estimate_size methods were removed from ProtoCoderImpl and ProtoPlusCoderImpl.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• sdks/python/apache_beam/coders/coder_impl.py
  • Removed the estimate_size method from the ProtoCoderImpl class.
  • Removed the estimate_size method from the ProtoPlusCoderImpl class.

Activity

• The pull request was created to revert a previous change.
• Automated checks for Python, Java, and Go tests are linked in the PR description.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[stankiewicz]

R: @robertwb
R: @kennknowles

[github-actions]

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

[damccorm]

Just adding some context - we noticed that the PR being reverted causes some existing use cases to fail. Specifically, if you have a proto which does not set all required fields, value.ByteSize() will fail while the other encoding/decoding is able to succeed.

While maybe unusual, I think it is valid to construct a proto throughout your beam pipeline and have only some fields filled in between steps, so I think we should support encoding/decoding protos like this where possible.

@robertwb any thoughts? One option is to just merge #37710 in the release branch to give us more time to figure this out