Skip to content

Comments

Iceberg Add Files#37701

Draft
ahmedabu98 wants to merge 2 commits intoapache:masterfrom
ahmedabu98:iceberg_add_files
Draft

Iceberg Add Files#37701
ahmedabu98 wants to merge 2 commits intoapache:masterfrom
ahmedabu98:iceberg_add_files

Conversation

@ahmedabu98
Copy link
Contributor

Simple transform that:

  1. Receives a PCollection of filepaths
  2. Converts them to DataFiles objects (reconstructing metrics and partition metadata)
  3. Commits a new snapshot referencing those DataFiles

Thereby adding DataFile references to a table without having to physically rewrite them into the destination table.

Note: Partitions are reconstructed based on hive-style partitioning

@ahmedabu98 ahmedabu98 marked this pull request as draft February 24, 2026 18:06
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @ahmedabu98, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new Apache Beam SchemaTransform designed to streamline the process of adding existing data files to an Apache Iceberg table. The transform efficiently integrates external data by converting file paths into Iceberg DataFile objects, reconstructing necessary metadata, and then committing these references to a new table snapshot. This approach supports both unpartitioned and hive-style partitioned tables, providing a robust mechanism for data ingestion without requiring physical data rewrites.

Highlights

  • Filepath processing: A PCollection of filepaths is received as input for the transformation.
  • DataFile conversion: Input filepaths are converted into Iceberg DataFiles objects, including the reconstruction of metrics and partition metadata.
  • Snapshot commitment: A new Iceberg snapshot is committed, referencing the newly created DataFiles, which allows adding files without physically rewriting data.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • sdks/java/io/iceberg/src/main/java/org/apache/beam/sdk/io/iceberg/AddFiles.java
    • Implemented the core AddFiles SchemaTransform, which processes file paths and commits them to an Iceberg table.
    • Defined ConvertToDataFile DoFn to infer file formats, extract metrics, and reconstruct partition paths from input file paths.
    • Included AddFilesDoFn to batch SerializableDataFile objects and commit them as a new snapshot to the target Iceberg table.
    • Provided utility methods for inferring file formats (Parquet, ORC, Avro) and retrieving file metrics.
  • sdks/java/io/iceberg/src/main/java/org/apache/beam/sdk/io/iceberg/AddFilesSchemaTransformProvider.java
    • Created a SchemaTransformProvider for the AddFiles transform, making it discoverable within Beam.
    • Defined the Configuration class using AutoValue to specify parameters such as Iceberg catalog details, table identifier, location prefix, and batching/triggering settings for streaming pipelines.
    • Registered the transform with the identifier "beam:schematransform:iceberg_add_files:v1".
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@ahmedabu98
Copy link
Contributor Author

Converting to draft until we add some tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant