cherry-pick - revert js2py to pythonmonkey into 2.72 release

[derrickaw]

Cherry-pick revert of js2py to pythonmonkey

Fixes - #37669

---

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

• Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
• Update CHANGES.md with noteworthy changes.
• If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

[gemini-code-assist]

Summary of Changes

Hello @derrickaw, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request reverses a prior decision to use pythonmonkey for JavaScript execution in Apache Beam's YAML components, reinstating js2py. The change addresses underlying issues that necessitated the revert, including ensuring proper serialization of JavaScript objects and managing js2py's compatibility with Python versions. It aims to stabilize the JavaScript mapping functionality by returning to a previously working solution while acknowledging js2py's limitations on newer Python environments.

Highlights

• Revert JavaScript Engine: The pull request reverts the previous change from pythonmonkey back to js2py for executing JavaScript mapping functions within Apache Beam's YAML transforms.
• CVE Fix Placeholder: The CHANGES.md file was updated to use a generic placeholder for a security fix, indicating the original CVE-2024-28397 fix related to the js2py to pythonmonkey switch is being re-evaluated or reverted.
• js2py Compatibility: The js2py dependency is now explicitly constrained to Python versions less than 3.12, addressing potential compatibility issues with newer Python releases.
• Pickling for JsObjectWrapper: A custom _CustomJsObjectWrapper class was introduced to correctly handle pickling of js2py.base.JsObjectWrapper objects, which previously had self-referencing __dict__ properties.
• YAML Transform Definition Update: The num_shards parameter was removed from the WriteToJson transform definition in standard_io.yaml.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• CHANGES.md
  • Updated the security fixes entry to a generic placeholder.
• sdks/python/apache_beam/yaml/standard_io.yaml
  • Removed the 'num_shards' parameter from the 'WriteToJson' transform.
• sdks/python/apache_beam/yaml/yaml_mapping.py
  • Removed imports and code related to 'pythonmonkey' and its dispatcher.
  • Reintroduced imports for 'js2py' and its base classes.
  • Added a '_CustomJsObjectWrapper' class to enable pickling of 'js2py.base.JsObjectWrapper' instances.
  • Modified '_expand_javascript_mapping_func' to utilize 'js2py' for JavaScript evaluation and result conversion.
• sdks/python/apache_beam/yaml/yaml_udf_test.py
  • Removed 'importlib' import.
  • Updated import logic to check for 'js2py' availability instead of 'pythonmonkey'.
  • Modified 'unittest.skipIf' decorators to conditionally skip tests based on 'js2py' installation.
• sdks/python/setup.py
  • Replaced the 'pythonmonkey' dependency with 'js2py', adding a version constraint for Python versions less than 3.12.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[derrickaw]

Run Python PreCommit 3.10

[github-actions]

Assigning reviewers:

R: @damccorm for label python.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

• stop reviewer notifications - opt out of the automated review tooling
• remind me after tests pass - tag the comment author after tests pass
• waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

[derrickaw]

Run Python_ML PreCommit 3.10

[damccorm]

Thanks!