Skip to content

[Dataflow Streaming] Mark support for windmill state tag encoding v2 #37683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
scwhittle merged 3 commits into from
Feb 24, 2026
+14 −2
Merged

[Dataflow Streaming] Mark support for windmill state tag encoding v2 #37683

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e26023e
[Dataflow Streaming] Mark support for windmill state tag encoding v2
arunpandianp Feb 23, 2026
65e26f9
remove todo
arunpandianp Feb 23, 2026
f5a3186
fix test
arunpandianp Feb 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions ...le-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowRunner.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1299,6 +1299,17 @@ public DataflowPipelineJob run(Pipeline pipeline) {
if (shouldActAsStreaming(pipeline)) {
options.setStreaming(true);

{
List<String> experiments =
options.getExperiments() == null
? new ArrayList<>()
: new ArrayList<>(options.getExperiments());
// Experiment marking that the harness supports tag encoding v2
// Backend will enable tag encoding v2 only if the harness supports it.
experiments.add("streaming_engine_state_tag_encoding_v2_supported");
options.setExperiments(ImmutableList.copyOf(experiments));
}

if (useUnifiedWorker(options)) {
options.setEnableStreamingEngine(true);
List<String> experiments =
Expand Down
5 changes: 3 additions & 2 deletions ...loud-dataflow-java/src/test/java/org/apache/beam/runners/dataflow/DataflowRunnerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
import static org.hamcrest.Matchers.equalTo;
import static org.hamcrest.Matchers.hasEntry;
import static org.hamcrest.Matchers.hasItem;
import static org.hamcrest.Matchers.hasItems;
import static org.hamcrest.Matchers.hasKey;
import static org.hamcrest.Matchers.hasProperty;
import static org.hamcrest.Matchers.instanceOf;
Expand Down Expand Up @@ -1791,7 +1792,7 @@ public void testSettingAnyFnApiExperimentEnablesUnifiedWorker() throws Exception
assertFalse(options.isEnableStreamingEngine());
assertThat(
options.getExperiments(),
containsInAnyOrder(
hasItems(
"beam_fn_api", "use_runner_v2", "use_unified_worker", "use_portable_job_submission"));
}

Expand All @@ -1807,7 +1808,7 @@ public void testSettingAnyFnApiExperimentEnablesUnifiedWorker() throws Exception
assertTrue(options.isEnableStreamingEngine());
assertThat(
options.getExperiments(),
containsInAnyOrder(
hasItems(
"beam_fn_api",
"use_runner_v2",
"use_unified_worker",
Expand Down
Loading