Skip to content

Fix type checking failure with Python 3.10+ union pipe syntax (int | None) #37645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jrmccluskey merged 3 commits into from
Feb 19, 2026
+28 −3
Merged

Fix type checking failure with Python 3.10+ union pipe syntax (int | None) #37645

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f0f3839
Fix type checking failure with Python 3.10+ union pipe syntax (int | …
junaiddshaukat Feb 19, 2026
d0c5302
Fix yapf formatting in test file
junaiddshaukat Feb 19, 2026
701dbd8
Address review: merge UnionType check into existing elif, remove issu…
junaiddshaukat Feb 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions sdks/python/apache_beam/typehints/typehints.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1462,9 +1462,10 @@ def normalize(x, none_as_type=False):
# Convert bare builtin types to correct type hints directly
elif x in _KNOWN_PRIMITIVE_TYPES:
return _KNOWN_PRIMITIVE_TYPES[x]
elif getattr(x, '__module__',
None) in ('typing', 'collections', 'collections.abc') or getattr(
x, '__origin__', None) in _KNOWN_PRIMITIVE_TYPES:
elif isinstance(x, types.UnionType) or getattr(
x, '__module__',
None) in ('typing', 'collections', 'collections.abc') or getattr(
x, '__origin__', None) in _KNOWN_PRIMITIVE_TYPES:
beam_type = native_type_compatibility.convert_to_beam_type(x)
if beam_type != x:
# We were able to do the conversion.
Expand Down
24 changes: 24 additions & 0 deletions sdks/python/apache_beam/typehints/typehints_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1596,6 +1596,22 @@ def test_hint_helper(self):
self.assertFalse(is_consistent_with(Union[str, int], str))
self.assertFalse(is_consistent_with(str, NonBuiltInGeneric[str]))

def test_hint_helper_pipe_union(self):
Copy link
Contributor

@jrmccluskey jrmccluskey Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having the extra test coverage is nice but it's worth noting that this suite passes even without the changes to typehints.py

pipe_union = int | None # pylint: disable=unsupported-binary-operation
typing_union = Union[int, None]
self.assertTrue(is_consistent_with(int, pipe_union))
self.assertTrue(is_consistent_with(type(None), pipe_union))
self.assertFalse(is_consistent_with(str, pipe_union))
self.assertTrue(
is_consistent_with(int, pipe_union) == is_consistent_with(
int, typing_union))
self.assertTrue(
is_consistent_with(str, pipe_union) == is_consistent_with(
str, typing_union))
pipe_union_2 = int | float # pylint: disable=unsupported-binary-operation
self.assertTrue(is_consistent_with(int, pipe_union_2))
self.assertTrue(is_consistent_with(float, pipe_union_2))

def test_positional_arg_hints(self):
self.assertEqual(typehints.Any, _positional_arg_hints('x', {}))
self.assertEqual(int, _positional_arg_hints('x', {'x': int}))
Expand Down Expand Up @@ -1934,6 +1950,14 @@ def test_pipe_operator_as_union(self):
native_type_compatibility.convert_to_beam_type(type_a),
native_type_compatibility.convert_to_beam_type(type_b))

def test_normalize_pipe_union(self):
pipe_union = int | None # pylint: disable=unsupported-binary-operation
normalized = typehints.normalize(pipe_union)
self.assertIsInstance(normalized, typehints.UnionConstraint)
pipe_union_2 = int | float # pylint: disable=unsupported-binary-operation
normalized_2 = typehints.normalize(pipe_union_2)
self.assertIsInstance(normalized_2, typehints.UnionConstraint)


class TestNonBuiltInGenerics(unittest.TestCase):
def test_no_error_thrown(self):
Expand Down
Loading