Add S3-compatible storage support for Iceberg managed I/O#37615
Add S3-compatible storage support for Iceberg managed I/O#37615dejii wants to merge 4 commits intoapache:masterfrom
Conversation
Summary of ChangesHello @dejii, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances Apache Beam's Iceberg Managed I/O capabilities by integrating support for AWS S3 and other S3-compatible object storage solutions. By adding the necessary Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Assigning reviewers: R: @Abacn for label java. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
R: @ahmedabu98 |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
|
@ahmedabu98 That’s awesome! I’ve had the change sitting in my fork for about two weeks and hadn’t checked the latest updates. I’ll give it another try with the current HEAD and share my feedback. Thanks! |
Summary
Adds AWS S3 and S3-compatible storage support (e.g., MinIO, Supabase Storage, etc.) to Beam’s Iceberg Managed I/O by including the
iceberg-awsmodule in the expansion service.Fixes: #37614
Background
Currently, the expansion service JAR bundles
iceberg-gcp, which enables Google Cloud Storage (GCS) support out of the box. However, it does not includeiceberg-aws, meaning S3-backed FileIO implementations (such as S3FileIO) are not available at runtime.As a result, attempts to read from or write to S3 or S3-compatible storage fail with a
ClassNotFoundExceptionfororg.apache.iceberg.aws.s3.S3FileIO.What This Change Does:
iceberg-awsdependency to the expansion service.This enables read and write capabilities for Apache Iceberg using configurations such as:
I have verified this functionality by building a custom expansion service JAR that includes iceberg-aws and successfully running a Dataflow job that writes to an S3-compatible storage backend. With the dependency present, the pipeline executes without the previous ClassNotFoundException, and read/write operations function as expected
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.