Skip to content

Fix Components visibility#37551

Merged
Abacn merged 1 commit intoapache:masterfrom
tarun-google:enable_component
Feb 9, 2026
Merged

Fix Components visibility#37551
Abacn merged 1 commit intoapache:masterfrom
tarun-google:enable_component

Conversation

@tarun-google
Copy link
Contributor

@tarun-google tarun-google commented Feb 9, 2026

Components is a dead code as of today. We already have throttler in this, it looks like a good place to add ratelimiter. With this fix i believe we enable dependency release for this component. let me know if there are any issues with this path.

Needed for #37547

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @tarun-google, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on improving the structural integrity and build system integration of the sdks/java/io/components module. By adding essential package information files and explicitly including the module in the Gradle build, the changes aim to make the module properly discoverable and usable. This foundational work is crucial for enabling future development and ensuring the module can be released as a dependency, paving the way for new features like a ratelimiter.

Highlights

  • Package Visibility: Introduced package-info.java files to explicitly define and document the deadletterqueue, deadletterqueue.sinks, and throttling packages within the sdks/java/io/components module, improving their visibility and structure.
  • Build System Integration: Added the sdks:java:io:components module to the settings.gradle.kts file, ensuring that this module is properly included in the Gradle build system and can be built and released as a dependency.
  • Enabling Future Development: These changes are foundational to enable the components module for dependency release and future enhancements, such as the integration of a ratelimiter, addressing its current status as 'dead code'.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • sdks/java/io/components/src/main/java/org/apache/beam/sdk/io/components/deadletterqueue/package-info.java
    • Added a new package-info.java file to define the deadletterqueue package and provide package-level documentation.
  • sdks/java/io/components/src/main/java/org/apache/beam/sdk/io/components/deadletterqueue/sinks/package-info.java
    • Added a new package-info.java file to define the deadletterqueue.sinks package and provide package-level documentation for DLQ sinks.
  • sdks/java/io/components/src/main/java/org/apache/beam/sdk/io/components/throttling/package-info.java
    • Added a new package-info.java file to define the throttling package and provide package-level documentation for throttling utilities.
  • settings.gradle.kts
    • Included the sdks:java:io:components module in the Gradle build configuration to ensure it is recognized and built.
Activity
  • No human activity (comments, reviews, or progress updates) has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2026

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@tarun-google
Copy link
Contributor Author

Run Java PreCommit

@tarun-google
Copy link
Contributor Author

R: @Abacn

@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2026

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

Copy link
Contributor

@Abacn Abacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Abacn Abacn merged commit 257fa5a into apache:master Feb 9, 2026
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants