Skip to content

Fix _OrderedUnionCoder is_deterministic check. #37550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
claudevdm merged 1 commit into from
Feb 9, 2026
Merged

Fix _OrderedUnionCoder is_deterministic check. #37550

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdks/python/apache_beam/coders/coders.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1512,7 +1512,7 @@ def _create_impl(self):

def is_deterministic(self) -> bool:
return (
all(c.is_deterministic for _, c in self._coder_types) and (
all(c.is_deterministic() for _, c in self._coder_types) and (
self._fallback_coder is None or
self._fallback_coder.is_deterministic()))

Expand Down
14 changes: 14 additions & 0 deletions sdks/python/apache_beam/coders/coders_test_common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1082,6 +1082,20 @@ def test_OrderedUnionCoder(self):
self.check_coder(test_coder, 123)
self.check_coder(test_coder, 1.5)

def test_OrderedUnionCoderDeterministic(self):
# CustomCoder is not deterministic therefore test_coder is not
# deterministic
test_coder = coders._OrderedUnionCoder((str, coders.StrUtf8Coder()),
(int, CustomCoder()),
fallback_coder=coders.FloatCoder())

self.assertFalse(test_coder.is_deterministic())

test_coder = coders._OrderedUnionCoder((str, coders.StrUtf8Coder()),
(int, coders.VarIntCoder()),
fallback_coder=coders.FloatCoder())
self.assertTrue(test_coder.is_deterministic())


if __name__ == '__main__':
logging.getLogger().setLevel(logging.INFO)
Expand Down
Loading