Fix Spotless in io:components

[tarun-google]

I plan to use this component for supporting ratelimiter. Fixing existing spotless issues.

I will be introducing this component in settings.gradle.kts in my Feature PR. that should apply spotless always.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

[gemini-code-assist]

Summary of Changes

Hello @tarun-google, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on enhancing code consistency and readability within the io:components module by applying the Spotless formatter. The changes are purely cosmetic, addressing whitespace, line breaks, and indentation across several Java source and test files. This ensures that the codebase aligns with predefined formatting standards, which is crucial for maintainability, especially for components supporting features like ratelimiting.

Highlights

• Code Formatting: Applied Spotless formatting to several Java files within the sdks/java/io/components module to ensure consistent code style and improve readability.
• Whitespace and Line Breaks: Adjusted whitespace, removed redundant blank lines, and refactored long lines in method signatures, constructor parameters, and Javadoc comments for better adherence to coding standards.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• sdks/java/io/components/src/main/java/org/apache/beam/sdk/io/components/deadletterqueue/DLQRouter.java
  • Removed an unnecessary blank line after the package declaration.
  • Refactored the class declaration and constructor parameters to span multiple lines for improved readability.
  • Adjusted indentation and line wrapping for the IllegalArgumentException message within the expand method.
• sdks/java/io/components/src/main/java/org/apache/beam/sdk/io/components/deadletterqueue/sinks/ThrowingSink.java
  • Removed an unnecessary blank line after the package declaration.
  • Reformated the processElement method signature to align with code style guidelines.
• sdks/java/io/components/src/main/java/org/apache/beam/sdk/io/components/throttling/ThrottlingSignaler.java
  • Reformated Javadoc comments for the class and the signalThrottling method to wrap long lines, enhancing readability.
• sdks/java/io/components/src/test/java/org/apache/beam/sdk/io/components/deadletterqueue/DLQRouterTest.java
  • Removed an unnecessary blank line after the package declaration.
  • Adjusted indentation for @Rule annotations.
  • Refactored PCollectionTuple creation and test method signatures to improve line wrapping and readability.

Activity

• No human activity has been recorded on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[github-actions]

Assigning reviewers:

R: @Abacn for label java.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

• stop reviewer notifications - opt out of the automated review tooling
• remind me after tests pass - tag the comment author after tests pass
• waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 35.86%. Comparing base (4e218f0) to head (a804607).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #37508      +/-   ##
============================================
- Coverage     35.87%   35.86%   -0.01%     
  Complexity     1676     1676              
============================================
  Files          1063     1063              
  Lines        166481   166467      -14     
  Branches       1208     1208              
============================================
- Hits          59722    59710      -12     
+ Misses       104578   104576       -2     
  Partials       2181     2181              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Abacn]

spotless should usually be auto applied and its violation is detected in beam_PreCommit_Spotless. Surprisingly, it appears this module is effectively dead code, never compiled and released because it is not declared in

https://github.com/tarun-google/beam/blob/master/settings.gradle.kts