Skip to content

Fix linting/compilation violation #37505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
damccorm merged 2 commits into from
Feb 4, 2026
Merged

Fix linting/compilation violation #37505

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
121a589
Fix linting/compilation violation
damccorm Feb 4, 2026
d57bc5b
fmt
damccorm Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion ...ava/org/apache/beam/runners/dataflow/worker/windmill/state/WindmillTagEncodingV2Test.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,7 +319,13 @@ public void testTimerTag() {
new Instant(123),
new Instant(456),
timeDomain)
: TimerData.of(TIMER_ID, namespace, new Instant(123), new Instant(456), timeDomain);
: TimerData.of(
TIMER_ID,
namespace,
new Instant(123),
new Instant(456),
timeDomain,
TimerData.CausedByDrain.NORMAL);
Copy link
Contributor Author

@damccorm damccorm Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Context: https://github.com/apache/beam/pull/37009/changes#r2765834617 changed the API, and this reverts us back to the behavior before that was merged (this test doesn't need any updated functionality)

assertEquals(expectedBytes, WindmillTagEncodingV2.instance().timerTag(prefix, timerData));
}
}
Expand Down
Loading