Update java ml module gradle#37471
Conversation
Summary of ChangesHello @Ganeshsivakumar, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on standardizing and refining the build configurations and code quality for the Java ML inference modules, specifically for OpenAI integration and the remote inference framework. It transitions to a more declarative Gradle setup for Java projects, enhances code readability through reformatting, and improves type safety and documentation, contributing to a more maintainable and robust codebase. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Assigning reviewers: R: @chamikaramj for label java. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
@gemini-code-assist review |
There was a problem hiding this comment.
Code Review
This pull request primarily consists of code reformatting across the openai and remote inference modules, likely from an automated tool, to align with project coding styles. It also updates the Gradle build configurations for these modules to use conventional project functions like applyJavaNature. Additionally, some minor but beneficial improvements have been made, such as adding package-level documentation and improving type safety in the RemoteInference transform. I've found a bug in an integration test that uses a non-existent OpenAI model and a small opportunity to improve a log message for better debuggability. My detailed comments are below.
...rence/openai/src/test/java/org/apache/beam/sdk/ml/inference/openai/OpenAIModelHandlerIT.java
Show resolved
Hide resolved
|
|
||
| attempt++; | ||
| LOG.warn("Retry request attempt {} failed with: {}. Retrying in {} ms", attempt, e.getMessage(), backoffMillis); | ||
| LOG.warn("Retry request attempt {} failed. Retrying in {} ms", attempt, backoffMillis, e); |
There was a problem hiding this comment.
While logging the full exception is a great improvement for debugging, the log message itself has lost some useful context by removing the exception message. You can include both the message for quick scanning and the full stack trace for deep dives.
| LOG.warn("Retry request attempt {} failed. Retrying in {} ms", attempt, backoffMillis, e); | |
| LOG.warn("Retry request attempt {} failed with: {}. Retrying in {} ms", attempt, e.getMessage(), backoffMillis, e); |
There was a problem hiding this comment.
This triggers lint error since passing exception is sufficient
[Slf4jDoNotLogMessageOfExceptionExplicitly] Do not log message returned from Throwable#getMessage and Throwable#getLocalizedMessage. It is enough to provide throwable instance as the last argument, then binding will log its message.
LOG.warn(
jrmccluskey
left a comment
There was a problem hiding this comment.
This is mostly formatting changes, everything else broadly LGTM (can address the one gemini review comment if you'd like)
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.