Skip to content

Update java ml module gradle#37471

Merged
jrmccluskey merged 4 commits intoapache:masterfrom
Ganeshsivakumar:update-gradle
Feb 4, 2026
Merged

Update java ml module gradle#37471
jrmccluskey merged 4 commits intoapache:masterfrom
Ganeshsivakumar:update-gradle

Conversation

@Ganeshsivakumar
Copy link
Contributor

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the java label Feb 2, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Ganeshsivakumar, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on standardizing and refining the build configurations and code quality for the Java ML inference modules, specifically for OpenAI integration and the remote inference framework. It transitions to a more declarative Gradle setup for Java projects, enhances code readability through reformatting, and improves type safety and documentation, contributing to a more maintainable and robust codebase.

Highlights

  • Gradle Build Configuration Updates: The Gradle build files for the openai and remote ML inference modules have been updated to use applyJavaNature for consistent module naming and Java 11 requirement. This replaces the direct id 'java' and id 'java-library' plugin declarations.
  • Module Metadata and Dependencies: New ext.summary properties have been added to the Gradle files for both openai and remote modules, providing brief descriptions. Integration testing dependencies and Java performance testing are now explicitly enabled for the openai module, and an unnecessary slf4j_simple test runtime dependency was removed from the remote module.
  • Code Formatting and Javadoc Improvements: Numerous Java source files across both openai and remote packages have undergone minor reformatting, including adjustments to whitespace, line breaks, and javadoc comments to improve readability and consistency. This includes correcting quotation marks in license headers.
  • Nullness Annotations and Type Specificity: The @SuppressWarnings("nullness") annotation has been added to OpenAIModelHandler and OpenAIModelParameters classes. Additionally, the handler() method in RemoteInference.Invoke now uses more specific type parameters for better type safety.
  • New Package Information Files: New package-info.java files have been added to both org.apache.beam.sdk.ml.inference.openai and org.apache.beam.sdk.ml.inference.remote packages, providing package-level documentation.
  • Gradle Settings File Correction: The settings.gradle.kts file was updated to correct the module include paths for sdks:java:ml:inference:remote and sdks:java:ml:inference:openai, ensuring they are properly recognized as subprojects.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2026

Assigning reviewers:

R: @chamikaramj for label java.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@jrmccluskey
Copy link
Contributor

@gemini-code-assist review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request primarily consists of code reformatting across the openai and remote inference modules, likely from an automated tool, to align with project coding styles. It also updates the Gradle build configurations for these modules to use conventional project functions like applyJavaNature. Additionally, some minor but beneficial improvements have been made, such as adding package-level documentation and improving type safety in the RemoteInference transform. I've found a bug in an integration test that uses a non-existent OpenAI model and a small opportunity to improve a log message for better debuggability. My detailed comments are below.


attempt++;
LOG.warn("Retry request attempt {} failed with: {}. Retrying in {} ms", attempt, e.getMessage(), backoffMillis);
LOG.warn("Retry request attempt {} failed. Retrying in {} ms", attempt, backoffMillis, e);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While logging the full exception is a great improvement for debugging, the log message itself has lost some useful context by removing the exception message. You can include both the message for quick scanning and the full stack trace for deep dives.

Suggested change
LOG.warn("Retry request attempt {} failed. Retrying in {} ms", attempt, backoffMillis, e);
LOG.warn("Retry request attempt {} failed with: {}. Retrying in {} ms", attempt, e.getMessage(), backoffMillis, e);

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This triggers lint error since passing exception is sufficient

 [Slf4jDoNotLogMessageOfExceptionExplicitly] Do not log message returned from Throwable#getMessage and Throwable#getLocalizedMessage. It is enough to provide throwable instance as the last argument, then binding will log its message.
          LOG.warn(

Copy link
Contributor

@jrmccluskey jrmccluskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is mostly formatting changes, everything else broadly LGTM (can address the one gemini review comment if you'd like)

@jrmccluskey jrmccluskey merged commit 0aea013 into apache:master Feb 4, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants