Conversation
Summary of ChangesHello @tarun-google, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a critical security vulnerability by upgrading the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Run Python_ML PreCommit 3.10 |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
| 'google-cloud-recommendations-ai>=0.1.0,<0.11.0', | ||
| 'google-cloud-aiplatform>=1.26.0, < 2.0', | ||
| 'cloud-sql-python-connector>=1.18.2,<2.0.0', | ||
| 'pyasn1>=0.6.2', |
There was a problem hiding this comment.
I would expect this to get automatically done the next time the dependency updater runs, so we shouldn't need the explicit callout in setup.py
This is a bit of an antipattern since we'd keep this requirement even if the underlying library which requires it removed the dependency.
There was a problem hiding this comment.
I kicked off the updater an extra time - https://github.com/apache/beam/actions/runs/21179791602 - it should create a pr to resolve this
There was a problem hiding this comment.
That created https://github.com/apache/beam/pull/37361/changes which does indeed bump this version. So we should be fine to close this PR
Fix Vulnerability b/476787539
Dependency update test run
https://github.com/tarun-google/beam/actions/runs/21147528718
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.