Merged
Conversation
de5991e to
42316a7
Compare
17 tasks
Contributor
|
Assigning reviewers: R: @damccorm for label python. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
damccorm
reviewed
Aug 19, 2025
Contributor
damccorm
left a comment
There was a problem hiding this comment.
Thanks - this generally LGTM. @jrmccluskey would you mind taking a look? (any useful context I might be missing from the last protobuf upgrade #32679 ?)
Contributor
|
unless there is some urgency, I would do it after the release cut, update dev containers, and test with internal user base to have more time to detect potential performance regressions. protobuf upgrades are hit-or-miss in my experience. |
Contributor
|
Reminder, please take a look at this pr: @damccorm |
Contributor
|
Merging since the cut has passed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why? Currently Apache Beam pins protobuf<6.0.0.dev0. Protobuf 6.30.0 was released on March 4, 2025: https://pypi.org/project/protobuf/6.30.0/, https://github.com/protocolbuffers/protobuf/releases/tag/v30.0 is the corresponding release.
Also fixed two flaky tests that became more flaky with the new Protobuf version. They were flaky because Protobuf doesn't guarantee map iteration order, so the sampler instances created here doesn't guarantee
'a'is the first and'b'is the second sampler when the tests useself.make_test_descriptor(outputs=['a', 'b']).Fixes #35432.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.