Add informal Python 3.13 support#35018
Conversation
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
|
Assigning reviewers: R: @liferoad for label python. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
| greenlet==3.2.2 | ||
| grpc-google-iam-v1==0.14.2 | ||
| grpc-interceptor==0.15.4 | ||
| grpcio==1.72.0rc1 |
There was a problem hiding this comment.
was this line manually edited to install an RC version? does it have the fix?
There was a problem hiding this comment.
that was not intended, I generated this file with the generatePythonRequirements workflow and it seems to pick up RC versions when I don't want it to. I bumped it back down to 1.71.0
| from apache_beam.testing.test_pipeline import TestPipeline | ||
|
|
||
| MAX_SUPPORTED_PYTHON_VERSION = (3, 8) | ||
| MAX_SUPPORTED_PYTHON_VERSION = (3, 13) |
There was a problem hiding this comment.
could you remind me please, what is the impact of this change?
There was a problem hiding this comment.
This is one I genuinely just saw while I was going through the code base and updated (since 3.8 hasn't been the max supported python version in quite some time.) I don't think the variable is particularly load bearing since we haven't been using 3.8 for months
2 participants
Introduces the changes to the package itself, gradle, and tox definitions to include Python 3.13 support. Does not automatically create or publish python 3.13 containers, nor does it add Python 3.13 testing to GitHub Actions workflows (hence the term "informal support.") Actions workflow updates will be done in a follow-up with changes living on a branch of the mainline Beam repo for testing on our runners.
Part of #34869
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.