Make dill optional and fix coders.#34769
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #34769 +/- ##
============================================
- Coverage 56.50% 56.50% -0.01%
Complexity 3289 3289
============================================
Files 1180 1180
Lines 181262 181239 -23
Branches 3399 3399
============================================
- Hits 102423 102402 -21
+ Misses 75580 75577 -3
- Partials 3259 3260 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
64d2473 to
4e40fb6
Compare
|
PreCommit Python PVR Flink is flakey, saw this failure on other PRs/Runs |
544ce26 to
4b8e5e2
Compare
|
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions. |
|
This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. |
pickle_library=dill. We might have to also guard this change behind update compatibility flag incase it doesnt fail update compat checks but encoding starts failing. Alternatively we can fallback to using dill for decoding the type if cloudpickle is selected and decoding the type fails, but this might affect performance since decode_type is called on each element being decoded.Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.