Removed < 1.66 for grpcio by liferoad · Pull Request #34196 · apache/beam

liferoad · 2025-03-06T19:59:34Z

We can merge this after the Beam 2.64.0 release cut on March 19 to check whether grpcio still causes issues.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
Update CHANGES.md with noteworthy changes.
If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

github-actions · 2025-03-06T21:34:55Z

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @jrmccluskey for label python.

Available commands:

stop reviewer notifications - opt out of the automated review tooling
remind me after tests pass - tag the comment author after tests pass
waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

sdks/python/setup.py

tvalentyn

PTAL at test/lint errors.

Co-authored-by: tvalentyn <tvalentyn@users.noreply.github.com>

sdks/python/tox.ini

liferoad · 2025-03-09T17:05:19Z

.github/workflows/beam_PreCommit_Python_Coverage.yml

https://github.com/apache/beam/actions/runs/13738774760/job/38433034429?pr=34196

[gw5] [ 97%] FAILED apache_beam/runners/portability/portable_runner_test.py::PortableRunnerTestWithSubprocesses::test_combine_per_key

liferoad · 2025-03-09T17:09:36Z

https://github.com/apache/beam/actions/runs/13738774755/job/38433041471?pr=34196

025-03-08T23:22:50.1202749Z ============================= test session starts ==============================
2025-03-08T23:22:50.1203553Z platform linux -- Python 3.12.9, pytest-7.4.4, pluggy-1.5.0
2025-03-08T23:22:50.1204318Z cachedir: target/.tox-flink-runner-test/flink-runner-test/.pytest_cache
2025-03-08T23:22:50.1205305Z rootdir: /runner/_work/beam/beam/sdks/python/test-suites/portable/py312/build/srcs/sdks/python
2025-03-08T23:22:50.1206131Z configfile: pytest.ini
2025-03-08T23:22:50.1206753Z plugins: requests-mock-1.12.1, timeout-2.3.1, xdist-3.6.1, hypothesis-6.127.9
2025-03-08T23:22:50.1208083Z timeout: 600.0s
2025-03-08T23:22:50.1208502Z timeout method: signal
2025-03-08T23:22:50.1208949Z timeout func_only: False
2025-03-08T23:22:50.1209503Z collected 216 items
2025-03-08T23:22:50.1209756Z 
2025-03-09T00:32:54.1212612Z apache_beam/runners/portability/flink_runner_test.py FFFFFFsFFFsFFFsssFF [  8%]
2025-03-09T01:11:18.5562788Z ##[error]The operation was canceled.

tvalentyn · 2025-03-12T14:41:35Z

Also launched GoPortable presubmit suite on these changes: https://github.com/apache/beam/actions/runs/13814130500

That is the suite that was previously failing on new versions of grpc.

liferoad · 2025-03-15T16:49:15Z

grpcio==1.71.0 seems not working well. many tests keep failing: https://github.com/apache/beam/actions/runs/13873590601/job/38823181322?pr=34196

liferoad · 2025-03-15T17:52:33Z

https://github.com/apache/beam/actions/runs/13814130500/job/38824779287 also keeps failing.

liferoad · 2025-03-16T12:52:52Z

1.71: still timeout for many tests.

github-actions · 2025-03-24T12:14:59Z

Reminder, please take a look at this pr: @jrmccluskey

github-actions · 2025-03-27T12:15:34Z

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @damccorm for label python.

Available commands:

stop reviewer notifications - opt out of the automated review tooling
remind me after tests pass - tag the comment author after tests pass
waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

liferoad · 2025-03-27T14:11:58Z

Mark this as a blocker for Beam 2.65.0.

github-actions · 2025-04-04T12:14:55Z

Reminder, please take a look at this pr: @damccorm

liferoad · 2025-04-04T13:24:01Z

blocked by grpc/grpc#39113

damccorm · 2025-04-04T13:29:56Z

stop reviewer notifications

github-actions · 2025-04-04T13:31:07Z

Stopping reviewer notifications for this pull request: requested by reviewer. If you'd like to restart, comment assign set of reviewers

tvalentyn · 2025-04-04T20:51:15Z

note: there may be additional, yet to be studied issue in grpc 1.66.0., the original reason why the upper bound was introduced.

Abacn · 2025-04-24T18:06:50Z

is this still targeted to 2.65.0 ? cc: @liferoad @tvalentyn

liferoad · 2025-06-26T11:14:00Z

grpc/grpc#39894 is out to fix this with 1.73.1

liferoad · 2025-06-26T13:06:38Z

1.73.1 is working well:

damccorm · 2025-06-26T13:21:54Z

sdks/python/setup.py

-          'grpcio>=1.67.0; python_version >= "3.13"',
+          # any version between 1.68.0 and 1.73.0 is bad
+          # external issue: https://github.com/grpc/grpc/issues/37710
+          'grpcio>=1.33.1,<1.74.0,!=1.48.0,!=1.59.*,!=1.60.*,!=1.61.*,!=1.62.0,!=1.62.1,!=1.68.*,!=1.69.*,!=1.70.*,!=1.71.*,!=1.72.*,!=1.73.0; python_version <= "3.12"',  # pylint: disable=line-too-long


Do we still need the <1.74.0 condition? Theoretically grpcio should have forward compatibility, and blocking this could lead to dependency conflicts. It would also be nice to allow the same versions which we allow for 3.13.

I'd also be fine waiting a few releases to see if grpcio remains stable for us though

We probably do no need <1.74.0 but given the wide range has caused a lot of issues for us, I would suggest we use the tighter bound with Python <= 3.12.

Ok - I'm fine with this for now, eventually I'd like to get rid of it once we've built some confidence in this again

I would use the same upper bound for all python versions. I think it should be fine to keep the first line and remove the python_version modifier.

Also, we should check if Go tests still break with this.

Also, we should check if Go tests still break with this.

Launched https://github.com/apache/beam/actions/runs/15907748034

damccorm · 2025-06-26T13:22:12Z

Thanks for following up on this

liferoad · 2025-06-26T16:29:57Z

I am going to merge this now so we have more time to test the potential impact from this.

This reverts commit 7b63aec.

* Removed < 1.66 for grpcio * Update sdks/python/setup.py Co-authored-by: tvalentyn <tvalentyn@users.noreply.github.com> * updated the version upper bound * skip pip check for lint * try <1.71 * updated the grpcio range * use grpcio 1.73.1 --------- Co-authored-by: tvalentyn <tvalentyn@users.noreply.github.com>

Removed < 1.66 for grpcio

86722c6

liferoad requested a review from tvalentyn March 6, 2025 19:59

github-actions bot added the python label Mar 6, 2025

github-actions bot added the Next Action: Reviewers label Mar 6, 2025

tvalentyn reviewed Mar 7, 2025

View reviewed changes

sdks/python/setup.py Outdated Show resolved Hide resolved

tvalentyn approved these changes Mar 7, 2025

View reviewed changes

liferoad and others added 3 commits March 7, 2025 10:08

Update sdks/python/setup.py

a5d6560

Co-authored-by: tvalentyn <tvalentyn@users.noreply.github.com>

updated the version upper bound

4cc9433

skip pip check for lint

d6fd6fa

liferoad requested a review from tvalentyn March 8, 2025 16:42

liferoad commented Mar 8, 2025

View reviewed changes

sdks/python/tox.ini Show resolved Hide resolved

Merge branch 'master' into gprcio-version

cda7831

try <1.71

12b4c3f

github-actions bot added the slow-review label Mar 24, 2025

github-actions bot removed the slow-review label Mar 27, 2025

liferoad added this to the 2.65.0 Release milestone Mar 27, 2025

github-actions bot added the slow-review label Apr 4, 2025

liferoad modified the milestones: 2.65.0 Release, 2.66.0 Release Apr 24, 2025

liferoad added 2 commits June 2, 2025 21:18

Merge branch 'master' into gprcio-version

da2a025

updated the grpcio range

07dedd0

damccorm modified the milestones: 2.66.0 Release, 2.67.0 Release Jun 5, 2025

Merge branch 'master' into gprcio-version

64ec755

liferoad closed this Jun 26, 2025

liferoad reopened this Jun 26, 2025

use grpcio 1.73.1

cbf0682

liferoad changed the title ~~[DO NOT MERGE] Removed < 1.66 for grpcio~~ Removed < 1.66 for grpcio Jun 26, 2025

liferoad requested review from damccorm and jrmccluskey June 26, 2025 13:06

damccorm reviewed Jun 26, 2025

View reviewed changes

damccorm approved these changes Jun 26, 2025

View reviewed changes

liferoad merged commit 7b63aec into apache:master Jun 26, 2025
96 of 97 checks passed

liferoad added a commit that referenced this pull request Jun 26, 2025

Revert "Removed < 1.66 for grpcio (#34196)"

23ccd8a

This reverts commit 7b63aec.

liferoad mentioned this pull request Jun 26, 2025

Revert "Removed < 1.66 for grpcio" #35451

Merged

liferoad added a commit that referenced this pull request Jun 26, 2025

Revert "Removed < 1.66 for grpcio (#34196)" (#35451)

296a614

This reverts commit 7b63aec.

Conversation

liferoad commented Mar 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

GitHub Actions Tests Status (on master branch)

Uh oh!

github-actions bot commented Mar 6, 2025

Uh oh!

Uh oh!

tvalentyn left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

liferoad commented Mar 9, 2025

Uh oh!

liferoad commented Mar 9, 2025

Uh oh!

tvalentyn commented Mar 12, 2025

Uh oh!

liferoad commented Mar 15, 2025

Uh oh!

liferoad commented Mar 15, 2025

Uh oh!

liferoad commented Mar 16, 2025

Uh oh!

github-actions bot commented Mar 24, 2025

Uh oh!

github-actions bot commented Mar 27, 2025

Uh oh!

liferoad commented Mar 27, 2025

Uh oh!

github-actions bot commented Apr 4, 2025

Uh oh!

liferoad commented Apr 4, 2025

Uh oh!

damccorm commented Apr 4, 2025

Uh oh!

github-actions bot commented Apr 4, 2025

Uh oh!

tvalentyn commented Apr 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Abacn commented Apr 24, 2025

Uh oh!

liferoad commented Jun 26, 2025

Uh oh!

liferoad commented Jun 26, 2025

Uh oh!

damccorm Jun 26, 2025

Choose a reason for hiding this comment

Uh oh!

liferoad Jun 26, 2025

Choose a reason for hiding this comment

Uh oh!

damccorm Jun 26, 2025

Choose a reason for hiding this comment

Uh oh!

tvalentyn Jun 26, 2025

Choose a reason for hiding this comment

Uh oh!

tvalentyn Jun 26, 2025

Choose a reason for hiding this comment

Uh oh!

tvalentyn Jun 26, 2025

Choose a reason for hiding this comment

Uh oh!

damccorm commented Jun 26, 2025

Uh oh!

liferoad commented Jun 26, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

liferoad commented Mar 6, 2025 •

edited

Loading

tvalentyn commented Apr 4, 2025 •

edited

Loading