Remove amazon-web-services and kinesis folders + settings.gradle cleanup#33456
Merged
Remove amazon-web-services and kinesis folders + settings.gradle cleanup#33456
Conversation
…mccorm/aws-v1-removal-final
Contributor
Author
damccorm
changed the title
Contributor
Author
|
Actually, moving back to draft. I missed one more piece which needs to be dealt with first - |
damccorm
changed the title
Contributor
Author
|
Ok - should be fine/ready for review now. It was a simple fix after all since updating the filesystem for tests has no real implications here. |
damccorm
changed the title
Contributor
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
1 similar comment
Contributor
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
This was referenced Dec 30, 2024
stankiewicz
pushed a commit
to stankiewicz/beam
that referenced
this pull request
Jan 16, 2025
…nup (apache#33456) * Remove amazon-web-services and kinesis folders + settings.gradle cleanup * remove aws v1 from settings * move BeamModulePlugin reference to v2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fully remove deprecated v1 aws IOs. #33416 and #33455 removed all dependencies of this, so this only deletes things. Specifically:
Part of #33430
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.