Bump yapf from 0.29.0 to 0.43.0 in /sdks/python#33112
Conversation
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
|
@damccorm do you know if this PR is still valid? |
It should be, updating this dep seems valid. Usually with dependabot I:
|
|
@dependabot rebase |
Bumps [yapf](https://github.com/google/yapf) from 0.29.0 to 0.43.0. - [Changelog](https://github.com/google/yapf/blob/main/CHANGELOG.md) - [Commits](google/yapf@v0.29.0...v0.43.0) --- updated-dependencies: - dependency-name: yapf dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
49b6278 to
3c001e6
Compare
|
Assigning reviewers. If you would like to opt out of this review, comment R: @tvalentyn for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Bumps [yapf](https://github.com/google/yapf) from 0.29.0 to 0.43.0. - [Changelog](https://github.com/google/yapf/blob/main/CHANGELOG.md) - [Commits](google/yapf@v0.29.0...v0.43.0) --- updated-dependencies: - dependency-name: yapf dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
|
This PR actually creates a mismatch in yapf versions. Updating yapf in pyproject.toml changes the version users would require to build the project, but our linting/formatting workflows still specify 0.29.0 (which is why this PR didn't break those precommits.) We can either revert this PR for now, or we can fix the workflows + re-yapf the code-base. Thoughts @damccorm @tvalentyn ? |
|
Good call - thanks for catching this. Lets just revert for now and then we can bump yapf everywhere later if we want to. |
|
Actually, I see you already have a pr to do the upgrade. We can take that if it doesn't have issues |
|
Threw together #33548 to see if that just works, will link workflow runs on that branch directly on the PR |
This reverts commit 1b78b67.
Bumps yapf from 0.29.0 to 0.43.0.
Changelog
Sourced from yapf's changelog.
... (truncated)
Commits
5cb90cbBump version to v0.43.029db8b7Actions(deps): Bump actions/checkout from 4.2.0 to 4.2.1 (#1249)89d1cd0Actions(deps): Bump peter-evans/create-pull-request from 6.0.2 to 7.0.5 (#1239)7e21823ylib2to3/pgen2/grammar: Fix Grammar.dump for parallel use with Grammar.load (...ed70540pre-commit: Add hook for yapf-diff (#1246)0de7684Actions(deps): Bump actions/checkout from 4.1.2 to 4.2.0 (#1241)b951457Fix CI (#1242)1afbf71Actions(deps): Bump actions/setup-python from 5.0.0 to 5.1.0 (#1218)fcd79bcActions(deps): Bump peter-evans/create-pull-request from 6.0.0 to 6.0.2 (#1213)507a900Actions(deps): Bump actions/checkout from 4.1.1 to 4.1.2 (#1212)You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)