MINOR: [Format] Fix incorrect bitmask examples and typos in Flight SQL and format #48697
+69
−69
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
968e6ea added incorrect bitmask examples for
SQL_SUPPORTED_TRANSACTIONS_ISOLATION_LEVELS.arrow/format/FlightSql.proto
Lines 588 to 590 in 968e6ea
The bitmask incorrectly mapped bit 2 (value 4 =
\b100) toSQL_TRANSACTION_REPEATABLE_READinstead ofSQL_TRANSACTION_READ_COMMITTED, and omittedSQL_TRANSACTION_READ_COMMITTEDentirely. According to the enum definition:arrow/format/FlightSql.proto
Lines 820 to 826 in 968e6ea
The correct bit-to-enum mapping should be:
SQL_TRANSACTION_NONE(enum value 0)SQL_TRANSACTION_READ_UNCOMMITTED(enum value 1)SQL_TRANSACTION_READ_COMMITTED(enum value 2)SQL_TRANSACTION_REPEATABLE_READ(enum value 3)SQL_TRANSACTION_SERIALIZABLE(enum value 4)What changes are included in this PR?
SQL_TRANSACTION_READ_COMMITTEDproperly in the comments.SQL positioned commands(presumably copied and pasted from other places) ->SQL transaction isolation levelsforSQL_SUPPORTED_TRANSACTIONS_ISOLATION_LEVELSSQL positioned commands(presumably copied and pasted from other places) ->SQL UNIONsforSQL_SUPPORTED_UNIONSAre these changes tested?
No, I did not test as they are comment-only.
Are there any user-facing changes?
No, dev-only.