Skip to content

Conversation

@HyukjinKwon
Copy link
Member

Rationale for this change

52d615d added this todo.

// TODO also handle HALF_FLOAT NaNs

After 4 years later, 72d20ad implemented the logic

if (Flags::nans_equal && std::isnan(x) && std::isnan(y)) {

if (Flags::nans_equal && f_x.is_nan() && f_y.is_nan()) {

This is being tested in

CheckFloatingNanEquality<FloatType>();
CheckFloatingNanEquality<DoubleType>();
CheckFloatingNanEquality<HalfFloatType>();

What changes are included in this PR?

This PR removes the obsolete todo about NaN handling at compare.cc.

Are these changes tested?

No, I did not test.

Are there any user-facing changes?

No.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant