Skip to content

Conversation

@pitrou
Copy link
Member

@pitrou pitrou commented Dec 17, 2025

Rationale for this change

A #include required on Valgrind (due to conditional compilation) was removed in PR #45462.

Are these changes tested?

Yes, by existing CI jobs.

Are there any user-facing changes?

No.

@pitrou
Copy link
Member Author

pitrou commented Dec 17, 2025

@github-actions crossbow submit -g cpp

@pitrou
Copy link
Member Author

pitrou commented Dec 17, 2025

@raulcd

@github-actions
Copy link

Revision: c992f2b

Submitted crossbow builds: ursacomputing/crossbow @ actions-3e51cc5fd8

Task Status
example-cpp-minimal-build-static GitHub Actions
example-cpp-minimal-build-static-system-dependency GitHub Actions
example-cpp-tutorial GitHub Actions
test-build-cpp-fuzz GitHub Actions
test-conda-cpp GitHub Actions
test-conda-cpp-valgrind GitHub Actions
test-cuda-cpp-ubuntu-22.04-cuda-11.7.1 GitHub Actions
test-cuda-cpp-ubuntu-24.04-cuda-13.0.2 GitHub Actions
test-debian-12-cpp-amd64 GitHub Actions
test-debian-12-cpp-i386 GitHub Actions
test-fedora-42-cpp GitHub Actions
test-ubuntu-22.04-cpp GitHub Actions
test-ubuntu-22.04-cpp-20 GitHub Actions
test-ubuntu-22.04-cpp-bundled GitHub Actions
test-ubuntu-22.04-cpp-emscripten GitHub Actions
test-ubuntu-22.04-cpp-no-threading GitHub Actions
test-ubuntu-24.04-cpp GitHub Actions
test-ubuntu-24.04-cpp-bundled-offline GitHub Actions
test-ubuntu-24.04-cpp-gcc-13-bundled GitHub Actions
test-ubuntu-24.04-cpp-gcc-14 GitHub Actions
test-ubuntu-24.04-cpp-minimal-with-formats GitHub Actions
test-ubuntu-24.04-cpp-thread-sanitizer GitHub Actions

@pitrou pitrou marked this pull request as ready for review December 17, 2025 09:18
@pitrou pitrou requested a review from raulcd December 17, 2025 09:18
Copy link
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the failure on test-ubuntu-24.04-cpp-thread-sanitizer isn't related but I haven't seen it anywhere else yet and I just triggered the cpp jobs on a different PR where all are green. It hasn't failed on the nightlies yet. Maybe is related to a commit on main, my PR isn't rebased to latest. I'll keep an eye for further failures on the job.

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Dec 17, 2025
@pitrou pitrou merged commit 016e3cf into apache:main Dec 17, 2025
46 of 48 checks passed
@pitrou pitrou removed the awaiting merge Awaiting merge label Dec 17, 2025
@pitrou pitrou deleted the gh48566-fix-valgrind branch December 17, 2025 09:55
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 016e3cf.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 56 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants