GH-48509: [GLib][Ruby] Add TrimOptions #48530
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
kou
reviewed
Dec 31, 2025
c_glib/arrow-glib/compute.cpp
Outdated
Comment on lines
7137
to
7144
| { | ||
| const gchar *characters = g_value_get_string(value); | ||
| if (priv->characters) { | ||
| g_free(priv->characters); | ||
| } | ||
| priv->characters = g_strdup(characters); | ||
| options->characters = characters ? characters : ""; | ||
| } |
Member
There was a problem hiding this comment.
Can we simplify this?
Suggested change
| { | |
| const gchar *characters = g_value_get_string(value); | |
| if (priv->characters) { | |
| g_free(priv->characters); | |
| } | |
| priv->characters = g_strdup(characters); | |
| options->characters = characters ? characters : ""; | |
| } | |
| options->characters = g_value_get_string(value); |
Contributor
Author
There was a problem hiding this comment.
Yes, I don't know why I thought that was needed. I removed the whole private struct.
stenlarsson
force-pushed
the
glib-trim-options
branch
from
7493114 to
902a2d0
Compare
github-actions
bot
added
awaiting committer review
stenlarsson
force-pushed
the
glib-trim-options
branch
from
902a2d0 to
a0fd322
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The
TrimOptionsclass is not available in GLib/Ruby, and it is used together with theutf8_trimcompute function.What changes are included in this PR?
This adds the
TrimOptionsclass to GLib.Are these changes tested?
Yes, with Ruby unit tests.
Are there any user-facing changes?
Yes, a new class.