Skip to content

Conversation

@stenlarsson
Copy link
Contributor

@stenlarsson stenlarsson commented Dec 14, 2025

Rationale for this change

The RankQuantileOptions class is not available in GLib/Ruby, and it is used together with the rank_quantile compute function.

What changes are included in this PR?

This adds the RankQuantileOptions class to GLib.

Are these changes tested?

Yes, with Ruby unit tests.

Are there any user-facing changes?

Yes, a new class.

@stenlarsson stenlarsson requested a review from kou as a code owner December 14, 2025 15:51
@github-actions
Copy link

⚠️ GitHub issue #48499 has been automatically assigned in GitHub to PR creator.

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@stenlarsson stenlarsson force-pushed the glib-rank-quantile-options branch from f1710fd to 8cb654a Compare December 29, 2025 21:56
@kou kou force-pushed the glib-rank-quantile-options branch from 8cb654a to 85bf356 Compare December 31, 2025 09:12
@kou kou merged commit cb184c6 into apache:main Dec 31, 2025
12 checks passed
@kou kou removed the awaiting review Awaiting review label Dec 31, 2025
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit cb184c6.

There weren't enough matching historic benchmark results to make a call on whether there were regressions.

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants