GH-48452: [Python] Add tests for Date32 and Date64 array creation with masks #48453
+91
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
icexelloss
reviewed
Dec 15, 2025
|
|
||
|
|
||
| def test_safe_cast_from_float_with_nans_to_int(): | ||
| # TODO(kszucs): write tests for creating Date32 and Date64 arrays, see |
Contributor
There was a problem hiding this comment.
This comment is for Date32 and Date64 types, is it correct to remove this comment? (New tests are float -> int)
Member
Author
There was a problem hiding this comment.
I was assuming that it is a mistake (from reading #3395 (comment)) ;-).
Member
There was a problem hiding this comment.
Yeah, it is a bit confusing. Maybe some info can be found in the code in this comment: #3395 (comment)
Member
Author
There was a problem hiding this comment.
Ah, thanks. Let me try!
Member
There was a problem hiding this comment.
I think current tests fit better! One more question, would we also use numpy when creating date arrays?
github-actions
bot
added
awaiting changes
HyukjinKwon
changed the title
HyukjinKwon
force-pushed
the
GH-48452
branch
from
7263573 to
71564e8
Compare
github-actions
bot
added
awaiting change review
HyukjinKwon
force-pushed
the
GH-48452
branch
from
71564e8 to
924a960
Compare
HyukjinKwon
force-pushed
the
GH-48452
branch
from
b551ecf to
060c546
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The original ticket ARROW-4258 missed the followup task, see also #3395 (comment)
Adding the test originally intended to test.
What changes are included in this PR?
Added the tests dates with masks
Are these changes tested?
Yes, manually tested as below:
Are there any user-facing changes?
No, test-only.