GH-47446: [C++] Update Meson configuration with compute swizzle change #47448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Contributor
Author
|
Hi @kou - could we merge this change? |
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 743d0af. There weren't enough matching historic benchmark results to make a call on whether there were regressions. The full Conbench report has more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The Meson configuration for compute was broken after the vector swizzle change was introduced; this gets the Meson configuration at parity with CMake again
What changes are included in this PR?
Move
vector_swizzle.cctolibarrowfromlibarrow_compute.See also: #47378
Are these changes tested?
Yes
Are there any user-facing changes?
No