feat: add is_there_null_pointing_to_non_empty_value helper function in OffsetBuffer#9711
Open
rluvaton wants to merge 1 commit intoapache:mainfrom
Open
feat: add is_there_null_pointing_to_non_empty_value helper function in OffsetBuffer#9711rluvaton wants to merge 1 commit intoapache:mainfrom
is_there_null_pointing_to_non_empty_value helper function in OffsetBuffer#9711rluvaton wants to merge 1 commit intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
In variable-length array types (e.g.,
StringArray,ListArray), null entries may have non-empty offset ranges, meaning the underlying data buffer contains data behind nulls. This matters when wanting to work on the underlying values of variable length data for example when unwrapping (flattening) a list array, as the child values are exposed, including those behind null entries. If null entries point to non-empty ranges, the unwrapped values will contain data that may not bemeaningful to operate on and could cause errors (e.g., division by zero in the child values).
Usages when this will be helpful:
What changes are included in this PR?
Add
OffsetBuffer::is_there_null_pointing_to_non_empty_valuemethod that checks if any null positions correspond to non-empty offsetranges
Are these changes tested?
Yes
Are there any user-facing changes?
Yes, a new public method
OffsetBuffer::is_there_null_pointing_to_non_empty_valueis added.Related to: