fix: handle Avro reader schema with no fields#9611
Open
mzabaluev wants to merge 1 commit intoapache:mainfrom
Open
fix: handle Avro reader schema with no fields#9611mzabaluev wants to merge 1 commit intoapache:mainfrom
mzabaluev wants to merge 1 commit intoapache:mainfrom
Conversation
github-actions
bot
added
arrow
mzabaluev-flarion
force-pushed
the
avro-empty-reader-schema
branch
from
f8a3f4a to
c518a19
Compare
rluvaton
reviewed
Apr 6, 2026
Comment on lines
+231
to
+515
| @@ -512,7 +512,7 @@ impl<R: AsyncFileReader + Unpin + 'static> AsyncAvroFileReader<R> { | |||
| // We have a full batch ready, emit it | |||
| // (This is not mutually exclusive with the block being finished, so the state change is valid) | |||
| if self.decoder.batch_is_full() { | |||
| return match self.decoder.flush() { | |||
| return match self.decoder.flush_block() { | |||
Contributor
Author
There was a problem hiding this comment.
It was something I noticed while tweaking: the OCF reader does not need the schema-updating code in flush. The method it calls to decode is decode_block, the logical companion to which is provided as flush_block.
Member
There was a problem hiding this comment.
is it required for the fix? if not can you please create a separate pr for this?
Contributor
|
fyi @jecsand838 |
Contributor
|
Marking as draft as I think this PR is no longer waiting on feedback and I am trying to make it easier to find PRs in need of review. Please mark it as ready for review when it is ready for another look |
In the degenerate case when the Avro reader schema has no fields, the RecordDecoder should be able to produce empty record batches with the number of rows counted from the data.
mzabaluev-flarion
force-pushed
the
avro-empty-reader-schema
branch
from
7be6a71 to
9175874
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
In the degenerate case when the Avro reader schema has no fields, the
RecordDecodershould be able to produce empty record batches with the number of rows counted from the data. As an optimization for OCF, the reader could skip decoding altogether, relying on record counts provided by data blocks.What changes are included in this PR?
A row counter is run in the
RecordDecoderstate.Are these changes tested?
Added tests to verify decoder behavior given an empty reader schema for the data files in the test suite.
Are there any user-facing changes?
No.