Avoid a clone when creating FixedSizeListArray from ArrayData#9187
Merged
alamb merged 3 commits intoapache:mainfrom Jan 21, 2026
Merged
Avoid a clone when creating FixedSizeListArray from ArrayData#9187alamb merged 3 commits intoapache:mainfrom
FixedSizeListArray from ArrayData#9187alamb merged 3 commits intoapache:mainfrom
Conversation
alamb
force-pushed
the
alamb/fixed_slize_list
branch
from
643bd46 to
c57d26c
Compare
alamb
commented
Jan 15, 2026
| let size = value_length as usize; | ||
| let values = | ||
| make_array(data.child_data()[0].slice(data.offset() * size, data.len() * size)); | ||
| let values = make_array(child_data[0].slice(offset * size, len * size)); |
Contributor
Author
There was a problem hiding this comment.
this still bothers me -- slice() allocates a bunch of new children ArrayDatas when I think it could mutate them in place. I'll see what I can do as a follow on PR
Closed
1 task
alamb
commented
Jan 18, 2026
| let values = make_array(child_data[0].slice(offset * size, len * size)); | ||
| Self { | ||
| data_type: data.data_type().clone(), | ||
| data_type, |
Contributor
Author
There was a problem hiding this comment.
this avoids a DataType::drop and a clone of a NullBuffer -- I don't expect this to be a huge deal performance wise but I am trying to make all the From impls consistent
Jefffrey
approved these changes
Jan 21, 2026
Contributor
Author
|
Thank you @Jefffrey |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
make_array) #9061ArrayData(speed up reading from Parquet reader) #9058Rationale for this change
Let's make arrow-rs the fastest we can and the fewer allocations the better
What changes are included in this PR?
Apply pattern from #9114
Are these changes tested?
Existing tests
Are there any user-facing changes?
No