Improve ArrowReaderBuilder::with_row_filter documentation#9153
Merged
alamb merged 4 commits intoapache:mainfrom Jan 14, 2026
Merged
Improve ArrowReaderBuilder::with_row_filter documentation#9153alamb merged 4 commits intoapache:mainfrom
ArrowReaderBuilder::with_row_filter documentation#9153alamb merged 4 commits intoapache:mainfrom
Conversation
alamb
commented
Jan 13, 2026
| @@ -1,49 +0,0 @@ | |||
| // Licensed to the Apache Software Foundation (ASF) under one | |||
Contributor
Author
There was a problem hiding this comment.
per https://github.com/apache/arrow-rs/pull/9115/changes#r2678450103 this is redundant with the doc example
alamb
commented
Jan 13, 2026
|
|
||
| /// Filter applied *during* the parquet read process | ||
| /// | ||
| /// See example on [`ArrowReaderBuilder::with_row_filter`] |
Contributor
Author
There was a problem hiding this comment.
just trying to backlink to make it easier to find examples/how to configure this
| /// let schema_desc = builder.metadata().file_metadata().schema_descr_ptr(); | ||
| /// | ||
| /// // Create predicate: column id > 4. This col has index 0. | ||
| /// // Create predicate that evaluates `int_col != 1`. |
Contributor
Author
There was a problem hiding this comment.
By using a column other than 0, we can illustrate the fact that the predicate is passed a record batch with a different schema
etseidl
approved these changes
Jan 14, 2026
Contributor
etseidl
left a comment
etseidl
left a comment
There was a problem hiding this comment.
Looks like an improvement to me. Just one nit.
Looks like I have to add a blog post to my read queue 🤣
Jefffrey
approved these changes
Jan 14, 2026
Co-authored-by: Ed Seidl <etseidl@users.noreply.github.com>
Contributor
Author
Dandandan
pushed a commit
to Dandandan/arrow-rs
that referenced
this pull request
Jan 15, 2026
) # Which issue does this PR close? - part of apache#9096 - Follow on to apache#9115 # Rationale for this change @sonhmai started us off with apache#9115 @Jefffrey and I had some suggestions on the PR and I found some more while going through it again, so I figured I would make anew PR # What changes are included in this PR? 1. Improve the documentation 2. Improve the doc comment example 3. Remove redundant example in parquet/examples/read_with_row_filter.rs # Are these changes tested? By CI # Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. If there are any breaking changes to public APIs, please call them out. --> --------- Co-authored-by: Ed Seidl <etseidl@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
@sonhmai started us off with #9115
@Jefffrey and I had some suggestions on the PR and I found some more while going through it again, so I figured I would make anew PR
What changes are included in this PR?
Are these changes tested?
By CI
Are there any user-facing changes?