[Variant] Move ArrayVariantToArrowRowBuilder to variant_to_arrow#9094
Merged
alamb merged 3 commits intoapache:mainfrom Jan 5, 2026
Merged
[Variant] Move ArrayVariantToArrowRowBuilder to variant_to_arrow#9094alamb merged 3 commits intoapache:mainfrom
ArrayVariantToArrowRowBuilder to variant_to_arrow#9094alamb merged 3 commits intoapache:mainfrom
Conversation
Contributor
Author
klion26
approved these changes
Jan 5, 2026
Member
klion26
left a comment
There was a problem hiding this comment.
Thanks for the contribution, LGTM
alamb
approved these changes
Jan 5, 2026
Contributor
alamb
left a comment
There was a problem hiding this comment.
Thanks @liamzwbao and @klion26
Contributor
|
Sorry I missed the notification, but this looks great, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
variant_get#8082.Rationale for this change
To support
Lists/Arrayinvariant_get, it's better to moveArrayVariantToArrowRowBuilderfromshred_varianttovariant_to_arrowand be shared withvariant_get. In the meantime, some code movement invariant_to_arrowwould help to get a better overview of the overall implementationWhat changes are included in this PR?
This PR can be reviewed commit by commit:
VariantToArrowRowBuilderand related impl to the top ofvariant_to_arrowFixedSizeListcheck frommake_variant_to_shredded_variant_arrow_row_builderdown toArrayVariantToArrowRowBuilderArrayVariantToArrowRowBuildertovariant_to_arrowAre these changes tested?
Covered by existing tests
Are there any user-facing changes?
No