Merged
Conversation
github-actions
bot
added
arrow
Closed
alamb
force-pushed
the
alamb/nullif_benchmark
branch
from
94fe993 to
d171d8b
Compare
Weijun-H
reviewed
Jan 4, 2026
| /// # Panic | ||
| /// | ||
| /// Panics if any of the [`BooleanArray`] contain nulls | ||
| #[inline(never)] |
Member
There was a problem hiding this comment.
Are these inline tags for profiling or performance?
Weijun-H
reviewed
Jan 4, 2026
| impl Default for RowSelectionPolicy { | ||
| fn default() -> Self { | ||
| Self::Auto { threshold: 32 } | ||
| Self::Auto { threshold: 16 } |
Contributor
Author
There was a problem hiding this comment.
this is a great call @Weijun-H -- this is left over code that was not indended for this PR. Sorry about that I will remove it
Jefffrey
approved these changes
Jan 10, 2026
Contributor
Author
Dandandan
pushed a commit
to Dandandan/arrow-rs
that referenced
this pull request
Jan 15, 2026
# Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. --> - related to apache#9085 - related to apache#9022 # Rationale for this change the `nullif` kernel has an optimization for counting nulls as part of applying nullif, and I did not know if that made a difference (turns out it does). I made a benchmark to be able to measure this difference # What changes are included in this PR? Add a `nullif_kernel` benchmark # Are these changes tested? I ran them manually # Are there any user-facing changes? No new benchmark
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
nullifkernel #9085BooleanBuffer::from_bitwise_binary#9022Rationale for this change
the
nullifkernel has an optimization for counting nulls as part of applying nullif, and I did not know if that made a difference (turns out it does).I made a benchmark to be able to measure this difference
What changes are included in this PR?
Add a
nullif_kernelbenchmarkAre these changes tested?
I ran them manually
Are there any user-facing changes?
No new benchmark