Skip to content

chore: increase row count and batch size for more deterministic tests #9088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alamb merged 2 commits into from
Jan 7, 2026
Merged

chore: increase row count and batch size for more deterministic tests #9088

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e3555ed
chore: increase row count and batch size for more deterministic tests
Weijun-H Jan 2, 2026
e25eb42
chore
Weijun-H Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions arrow-json/benches/serde.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,14 @@ use rand::{Rng, rng};
use serde::Serialize;
use std::sync::Arc;

const ROWS: usize = 1 << 18;

#[allow(deprecated)]
fn do_bench<R: Serialize>(c: &mut Criterion, name: &str, rows: &[R], schema: &Schema) {
let schema = Arc::new(schema.clone());
c.bench_function(name, |b| {
b.iter(|| {
let builder = ReaderBuilder::new(schema.clone()).with_batch_size(64);
let builder = ReaderBuilder::new(schema.clone()).with_batch_size(8192);
let mut decoder = builder.build_decoder().unwrap();
decoder.serialize(rows)
})
Expand All @@ -37,26 +39,26 @@ fn do_bench<R: Serialize>(c: &mut Criterion, name: &str, rows: &[R], schema: &Sc
fn criterion_benchmark(c: &mut Criterion) {
let mut rng = rng();
let schema = Schema::new(vec![Field::new("i32", DataType::Int32, false)]);
let v: Vec<i32> = (0..2048).map(|_| rng.random_range(0..10000)).collect();
let v: Vec<i32> = (0..ROWS).map(|_| rng.random_range(0..10000)).collect();

do_bench(c, "small_i32", &v, &schema);
let v: Vec<i32> = (0..2048).map(|_| rng.random()).collect();
let v: Vec<i32> = (0..ROWS).map(|_| rng.random()).collect();
do_bench(c, "large_i32", &v, &schema);

let schema = Schema::new(vec![Field::new("i64", DataType::Int64, false)]);
let v: Vec<i64> = (0..2048).map(|_| rng.random_range(0..10000)).collect();
let v: Vec<i64> = (0..ROWS).map(|_| rng.random_range(0..10000)).collect();
do_bench(c, "small_i64", &v, &schema);
let v: Vec<i64> = (0..2048)
let v: Vec<i64> = (0..ROWS)
.map(|_| rng.random_range(0..i32::MAX as _))
.collect();
do_bench(c, "medium_i64", &v, &schema);
let v: Vec<i64> = (0..2048).map(|_| rng.random()).collect();
let v: Vec<i64> = (0..ROWS).map(|_| rng.random()).collect();
do_bench(c, "large_i64", &v, &schema);

let schema = Schema::new(vec![Field::new("f32", DataType::Float32, false)]);
let v: Vec<f32> = (0..2048).map(|_| rng.random_range(0.0..10000.)).collect();
let v: Vec<f32> = (0..ROWS).map(|_| rng.random_range(0.0..10000.)).collect();
do_bench(c, "small_f32", &v, &schema);
let v: Vec<f32> = (0..2048).map(|_| rng.random_range(0.0..f32::MAX)).collect();
let v: Vec<f32> = (0..ROWS).map(|_| rng.random_range(0.0..f32::MAX)).collect();
do_bench(c, "large_f32", &v, &schema);
}

Expand Down
Loading