Skip to content

Switch from ryu -> zmij for float formatting #9047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
cijiugechu wants to merge 2 commits into
base: main
Choose a base branch
from
+7 −5
Draft

Switch from ryu -> zmij for float formatting #9047

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
19fa2ac
Switch from `ryu` -> `zmij` for float formatting
cijiugechu Dec 26, 2025
8ec1972
Merge branch 'main' into switch-to-zmij
alamb Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,8 @@ simdutf8 = { version = "0.1.5", default-features = false }

criterion = { version = "0.8.0", default-features = false }

zmij = "0.1"
Copy link
Copy Markdown
Contributor

@alamb alamb Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a dtonay special

https://crates.io/crates/zmij/versions

It is only 20 days old (it is already on version 1). I think we should wait a while for this crate to percolate through the ecosystem and see how it matures

Image


# release inherited profile keeping debug information and symbols
# for mem/cpu profiling
[profile.profiling]
Expand Down
2 changes: 1 addition & 1 deletion arrow-cast/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ lexical-core = { version = "1.0", default-features = false, features = ["write-i
atoi = "2.0.0"
comfy-table = { version = "7", optional = true, default-features = false }
base64 = "0.22"
ryu = "1.0.16"
zmij = { workspace = true }

[dev-dependencies]
criterion = { workspace = true, default-features = false }
Expand Down
2 changes: 1 addition & 1 deletion arrow-cast/src/display.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -672,7 +672,7 @@ macro_rules! primitive_display_float {
{
fn write(&self, idx: usize, f: &mut dyn Write) -> FormatResult {
let value = self.value(idx);
let mut buffer = ryu::Buffer::new();
let mut buffer = zmij::Buffer::new();
f.write_str(buffer.format(value))?;
Ok(())
}
Expand Down
2 changes: 1 addition & 1 deletion arrow-json/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ chrono = { workspace = true }
lexical-core = { version = "1.0", default-features = false}
memchr = "2.7.4"
simdutf8 = { workspace = true }
ryu = "1.0"
zmij = { workspace = true }
itoa = "1.0"

[dev-dependencies]
Expand Down
4 changes: 2 additions & 2 deletions arrow-json/src/reader/string_array.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ use crate::reader::ArrayDecoder;
use crate::reader::tape::{Tape, TapeElement};

use itoa;
use ryu;
use zmij;

const TRUE: &str = "true";
const FALSE: &str = "false";
Expand Down Expand Up @@ -88,7 +88,7 @@ impl<O: OffsetSizeTrait> ArrayDecoder for StringArrayDecoder<O> {

let mut builder = GenericStringBuilder::<O>::with_capacity(pos.len(), data_capacity);

let mut float_formatter = ryu::Buffer::new();
let mut float_formatter = zmij::Buffer::new();
let mut int_formatter = itoa::Buffer::new();

for p in pos {
Expand Down
Loading